Allow creation of custom connections. Fixes #65. #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it was not possible to create custom connections without monkey patching graphene.relay.connection. Custom connections are useful when all connections need a total count for paging, for example. We change the SQLAlchemyObjectType.__init_subclass_with_meta method so that when the connection argument is a class, it is used to create the new connection type. A test case has been added to check usage of custom connections. The `conftest.py` was added to allow pytest using database related fixtures in other places than `test_query.py`.
Author
|
I'm closing this request and reopen with rebased branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was not possible to create custom connections without
monkey patching graphene.relay.Connection. Custom connections are
useful when all connections need a total count for paging, for example.
We change the SQLAlchemyObjectType.__init_subclass_with_meta method
so that when the connection argument is a class, it is used to create
the new connection type.
A test case has been added to check usage of custom connections. The
conftest.pywas added to allow pytest using database related fixturesin other places than
test_query.py.